chore: clarify that ASP signs funding PSBT #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Hoenisch <[email protected]>
tiero
reviewed
Jul 17, 2024
| @@ -124,7 +124,7 @@ import TabItem from '@theme/TabItem'; | |||
| - ASP adds the added output in the [Funding transaction](#funding-transaction) shared by Alice. | |||
| - ASP spends from the `Alice + ASP` cooperative path. | |||
| - ASP adds the output with the script `(Alice + ASP) or (Alice after 24h)`. This output is the [VTXO](#vtxo) of Alice. | |||
| - ASP signs the PSBT and sends it to Alice. | |||
| - ASP signs the Funding PSBT and sends it to Alice. | |||
There was a problem hiding this comment.
no this is not correct, first is the Redeem transaction to be signed. After this, Alice can sign his original Funding.
- Change this Redeem PSBT (left suggestion)
- In the next sentence we can be more clear saying "It's now safe for Alice to sign and broadcast his funding.."
Suggested change
| - ASP signs the Funding PSBT and sends it to Alice. | |
| - ASP signs the Redeem PSBT, sends it to Alice who counter-signs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is my understanding correct, that the ASP is signing the funding PSBT?